-
Notifications
You must be signed in to change notification settings - Fork 807
[SYCL][Doc] Add sycl_ext_oneapi_device_is_integrated
spec extension
#20085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][Doc] Add sycl_ext_oneapi_device_is_integrated
spec extension
#20085
Conversation
is_gpu_integrated
query to sycl_ext_intel_device_info
sycl_ext_oneapi_device_is_integrated
spec extension
sycl/doc/extensions/proposed/sycl_ext_oneapi_device_is_integrated.asciidoc
Outdated
Show resolved
Hide resolved
Please update description on how it's different from https://registry.khronos.org/SYCL/specs/sycl-2020/html/sycl-2020.html#api:info-device-host-unified-memory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that an earlier version of this PR added the query to sycl_ext_intel_device_info. Why did you change your mind and add it as a separate extension?
If we need to add this query as both an info descriptor and also an aspect (telling whether the info descriptor is supported), then it might be better to add it to sycl_ext_intel_device_info because it matches the pattern we use there.
== Overview | ||
|
||
This extension allows host code to check whether a physical device, represented | ||
by a SYCL device, is integrated with the host. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest a slight rewording here because the difference between "integrated" and "discrete" isn't always clear cut:
This extension allows host code to check whether a SYCL GPU device is "integrated" or "discrete". An integrated GPU device often shares memory with the host CPU, while a discrete GPU is often a separate card with its own memory. However, some GPU devices may not fit neatly into either category, so implementors may provide their own judgement when categorizing a GPU device as "integrated" vs. "discrete".
@bashbaug does this seem like a reasonable description? Any suggestions?
sycl/doc/extensions/proposed/sycl_ext_oneapi_device_is_integrated.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_device_is_integrated.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_device_is_integrated.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_device_is_integrated.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_device_is_integrated.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_device_is_integrated.asciidoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@intel/llvm-gatekeepers please consider merging |
No description provided.